A lightning talk about how best practices promote a one-size-fits all mentality that harms our ability to create solutions that are tailored to the problems at hand
After reviewing almost all code we wrote for 18 months, completing some 1'500 reviews, we want to share some recommendations.
After setting out to create a peer review culture we came up with a workflow and picked a tool (yes, Crucible) that would help us get there.
At Disy we review almost all the code we write. Here, we want to share why that was not always the case and how we started with code reviews.
Code reviews should be brief, short, and focused. This is the story of how I fucked up on all those accounts and we still made it work.
Anonymous classes are verbose and obfuscating. Functional implementations can oust them from their last strongholds (mainly abstract classes).
Discussing the keynote "Workflows of Refactoring" by Martin Fowler at OOP 2014, where he categorizes different reasons for and ways of refactoring.